Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
breakinside awhilenested in anArray#eachblock is currently connected to the block's break vertex. Forfoo(flag), TypeProf infers(:b | Array[Integer]), as ifeachcould return the loop'sbreakvalue.This is not an infinite loop: when
flagis truthy, the body breaks immediately; otherwise, thewhileexits without entering the body.Array#eachshould therefore retain itsArray[Integer]return type.Give each loop body its own break vertex and restore the enclosing vertex after analysis so a loop-local
breakcannot escape the surrounding block.Test
Ran the focused scenario set:
break_in_loop.rb,break.rb,break2.rb, andloop.rb(4 scenarios, 9 assertions).